Viewing 15 posts - 1 through 15 (of 20 total)
  • Author
    Posts
  • #43986
    karlchick
    Participant

    Hi,
    There are a several alternative-values in the tags that I would really like to see as things that can be rendered seperately:
    – greenhouse (included in building)
    – storage_tank (included in building, but does not seem to be renderable at the moment)
    storage_tank should be listed as a node and a way under man_made (according to mapsforge). I really would like to render the ways so that they are visible on maps (e.g. places like water treatment works use these a lot).
    I would also like to be able to show greenhouses differently from normal buildings – there are a lot in my local area. LoMaps already support greenhouses.
    Ever hopeful, Karl.

    #43997
    Avatar photoTobias
    Keymaster

    Hi Karl,
    Christian who manages the map content is travelling at the moment so it will take a while until he can reply.

    – storage_tank (included in building, but does not seem to be renderable at the moment)

    This is working for me, e.g. here, ways with building=storage_tank it renders fine with latest maps/Elevate version:
    https://www.openstreetmap.org/way/361067175#map=19/48.04365/11.50957
    man_made=storage_tank isn’t included in tag-mapping, but rending building=yes (with equivalent storage_tank) works.

    Best regards,
    Tobias

    Developer of Elevate mapstyle

    #44011
    karlchick
    Participant

    Hi Tobias,
    For the storage tanks in my area they are not tagged with building, just man_made, e.g.

    https://www.openstreetmap.org/way/471634138#map=18/51.84076/-2.27651

    Hence I wondered if this was something that Christian might be able to fix…

    #44014
    Avatar photoTobias
    Keymaster

    For the storage tanks in my area they are not tagged with building, just man_made,

    Yes, that can’t be rendered although storage_tank is included in building, as each tag that you want to render has to be added to the map explicitly, so building=storage_tank isn’t working for that. Christian would to include man_made=storage_tank.

    So do you want man_made=storage_tank AND building=storage_tank to be added as separate tags (the latter not anymore as equivalent from building), or JUST man_made=storage_tank?
    In my experience building=anything isn’t very reliably used if a different similar tag exists, so if you want to render it, man_made should work better.

    Developer of Elevate mapstyle

    #44083
    karlchick
    Participant

    Hi Tobias,

    To be honest I don’t really mind how it is tagged, just that I can render it. If you think man_made=storage_tank is best then that will do.

    By the way, is there anyway to use the equivalent-values independently of the key’s main value?

    e.g. if I try to use “greenhouse” for:

    <osm-tag key=”building” value=”farm_auxiliary” equivalent-values=”barn,greenhouse,shed,stable,garage,garages,cowshed,agricultural,sty,silo” zoom-appear=”14″/>

    I find that all buildings with value=”farm_auxiliary” are rendered using the same rule… is there anyway to render just greenhouses? or does this require a new key, e.g.

    <osm-tag key=”building” value=”greenhouse” zoom-appear=”14″/>

    #44085
    Avatar photoTobias
    Keymaster

    To be honest I don’t really mind how it is tagged, just that I can render it. If you think man_made=storage_tank is best then that will do.

    The problem with OSM is that you have to look into it to see what works best 🙁
    It’s just a rule of thumb that if a different tag with the same value as a building tag exists it’s usually to prefer.

    By the way, is there anyway to use the equivalent-values independently of the key’s main value?

    No, that doesn’t work. In the maps only the main tag is included, all equivalent tags are converted to the main tag.
    The tag-mapping has to be changed if building=greenhouse is included as separate tag, and all other themes which already render it as building=yes would have to be changed, too…

    Developer of Elevate mapstyle

    #44094
    karlchick
    Participant

    Hmm… seems unlikely that greenhouses would be separated out into its own tag (i.e. k=”building”, v=”greenhouse”) then… which would be shame. Locus Map’s LoMaps already have this as it makes a big difference if you are near an area with lots of greenhouses/glasshouses, which around my area there are quite a few, e.g. Evesham in the UK has a reasonable number of greenhouses for garden and agriculture purposes, they are much larger compared to other buildings.

    Attached are
    – a google SAT view,
    – the rendering in LoMaps (note diamond fill for glass houses / greenhouses
    – and the view using OAM (note they all appear as very large buildings)

    The theme I am using is my own one that tries replicate the UK Ordanance Survey 1:25,000 map look/feel. OS maps distinguish greenhouses by using this hatched/diamond fill. Hence my request. All the other alternative values for farm_auxiliary are OK to render as buildings (from my point of view).

    #44106
    karlchick
    Participant

    Here is an overpass-turbo query that shows that the OSM data contains the tagging information, it’s just that OAM tagg mapping merges it into a one group (farm_auxiliary). Just run the query to highlight the greehouses:

    OSM Greenhouses

    #44114
    Avatar photoTobias
    Keymaster

    I see your point, although I think the diamond fill looks more dominant than that of buildings 😉
    But in comparison to this your problem seems not so big:
    https://overpass-turbo.eu/s/19gE
    So I support the separation of building=greenhouse as a independent tag in tag-mapping, we have to wait what Christian says when he’s back.

    Developer of Elevate mapstyle

    1 user thanked author for this post.
    #44134
    karlchick
    Participant

    Hi Tobias,
    Yes the diamond fill is a bit bold. However, this is a theme that replicates the Ordnance Survey maps that are very well known and used in the UK, at that is the way they depict greenhouses. I might tone down the contrast of the pattern at bit and maybe increase the resolution too… that might help reduce the dominance a bit. Thanks for feedback and i really hope Christian agrees to split out greenhouses.

    #45025
    Avatar photoChristianK
    Keymaster

    greenhouses will be seperated in tagmapping end of year with next big update

    #46473
    karlchick
    Participant

    greenhouses will be seperated in tagmapping end of year with next big update

    Yay! Greenhouses are now rendering with the new v5 OAMs! THANK YOU and MERRY CHRISTMAS!
    Karl.

    1 user thanked author for this post.
    #46690
    karlchick
    Participant

    Christian, any chance of including Horse Racing Courses/Tracks into OAM? Looking at the latest tag-mapping for v5 OAM is would seem that k=”leisure” v=”ls_track” should/might pick these up, but I only see athletics tracks not horse racing tracks. LoMaps have always included horse racing courses/tracks. See attached examples of OSM data, OAM and LoMap renders.

    also… any update on including man_made = storage_tank mentioned in the first post?

    #46701
    Avatar photoChristianK
    Keymaster

    The problem is (was) that the one with sport=horse_racing is a relation – this should be cleared in next update.

    1 user thanked author for this post.
    #46707
    karlchick
    Participant

    Christian,
    Here are some more suggestions/requests for additional key values:
    Palaces/Stately Houses or combine as Historic_House, e.g.:
    – k=”building”, v=”palace” (osm uses historic=’castle’ & castle_type=’palace’)
    – k=”building”, v=”stately_house” (osm uses historic=’castle’ & castle_type=’stately’)
    – k=”building”, v=”historic_house” (osm uses historic=’castle’ & castle_type=’palace|stately’,
    Note: historic_house is also how Ordanance Survey classify these buildings.
    Cathedrals, LoMaps already define these and OS maps also indicate cathedrals differently from churches as they are usually significant landmarks. E.g.:
    – k=”building”, v=”cathedral” (this is how osm classify them)
    and of course the original request in post #1 for storage_tank:
    – k=”man_made”, v=”storage_tank” (as defined in OSM, but not in OAM).

    BTW, I really like that the hiking and cycling route names are now separated in v5, thank you.

Viewing 15 posts - 1 through 15 (of 20 total)
  • You must be logged in to reply to this topic.