Viewing 7 posts - 1 through 7 (of 7 total)
  • Author
    Posts
  • #38011

    Juanjo
    Participant

    Hi,
    I just saw that buildings tagged as building=kindergarten (and may be others) are not showed in OAM. First I thought that it was an issue of Elevete theme but, using the standard mapsforge theme, there are still not there, so it seems that those buildings are not imported from OSM at all.

    Is there a particular reason for this or is it just an oversight? After all, from a topographic map point of view, a building is a building.

    Regards

    #38027
    Tobias
    Tobias
    Moderator

    Every single value has to be defined in tag-mapping to appear in mapsforge maps. You can find the tag-mapping of OpenAndroMaps here:
    https://www.openandromaps.org/map-basics-2/tag-mapping
    So this is not on purpose, but no one reported ever reported before that building=kindergarten is missing.There are currently 12642 values for building in the OSM data, there are quite a few others missing, as only the more common ones are added. @ChristianK, can you add this?

    Developer of Elevate mapstyle

    #38063
    ChristianK
    ChristianK
    Keymaster

    Yes of cause.

    However, the only real way to solve this issue ist to implement a TagTransform rule to
    convert all building=(.*) to building=yes
    While I don’t like the idea cause 80% of the values are garbage it would be the only way to catch buildings.
    .. and all Buildings would be rendered in the same way and at same zoom-appear ??

    BTW: I assigned building=yes to WAY .AND: NODE
    Is this OK ???
    IMO a building is a WAY

    Christian

    #38076

    Juanjo
    Participant

    Hi Tobias, Christian,

    thank you for looking at this.

    Personally, I am OK with all buildings appearing at the same zoom level but I am concerned by rendering all of them in the same way. I personally requested some time ago to render ‘building=ruins’ in a different way, which Tobias kindly did.

    I am not familiar with mapsforge tag mapping but, is my understanding correct that, in V5 maps, using wildcards, all the buildings can be imported AND the tag value will be preserved?

    <attribute name="value" use="required">
    	<annotation>
    		<documentation>
    			The value of the OpenStreetMap tag. E.g. 'primary'
    			in the tag 'highway=primary'.
    			If tags have no fixed values, you can use "%f" for float and other
    			numeric values and "%s" for string values. Avoid using the string
    			wildcard, as it causes much overhead. Instead use OSM specific strings.
    			Color strings and hex codes can be declared as numeric values too.
    		</documentation>
    	</annotation>

    If it is the case, this is one more good reason to move to V5 maps ;-)
    Regards

    #38092
    Tobias
    Tobias
    Moderator

    While I don’t like the idea cause 80% of the values are garbage it would be the only way to catch buildings.

    As long as it’s just with the key “building” and nothing else (like: “abondoned:building” etc.) it will mostly be fine. Only exceptions should be possible, like the mentioned building=ruins and building=construction. I don’t know at the moment if there’s any other really special value available, which refers to the condition of the building and not just the function. I think the former is important in rendering it, the latter isn’t.

    .. and all Buildings would be rendered in the same way and at same zoom-appear ??

    I think so, except of those in special conditions (see above) might render differently. When you think of classic maps or satellite photos, buildings are either all shown or not, and all at the same scale.

    BTW: I assigned building=yes to WAY .AND: NODE
    Is this OK ???
    IMO a building is a WAY

    I agree to your last sentence, nodes are more a kind of place holder. The Wiki says:
    “Note about using this tag on nodes : although buildings are better represented with their footprints (a closed way or a multipolygon relation), OSM is working by iteration and some areas in the world don’t have good aerial imagery or public datasets offering building footprints. Therefore, buildings on nodes should be tolerated until better sources are available.” There are only 1486 nodes, so it doesn’t really matter. I wouldn’t render them with Elevate.

    Developer of Elevate mapstyle

    #38098
    ChristianK
    ChristianK
    Keymaster

    Hi Tobias,

    like the mentioned building=ruins and building=construction

    rhere are values like “destroyed” aso..

    I agree that a rule to convert all values to “yes” with some exeptions will be the best tradeoff.

    Ok, this is next on my TODO.

    Have a nice weekend!
    Christian

    1 user thanked author for this post.
    #38108
    Tobias
    Tobias
    Moderator

    I’ve done a quick analysis of all values which occur more than 100 times. There’s some values in languages i don’t know, and some strange ones, but here are those that refer to conditions with suggestions:

    construction
    constructie
    constraction
    en construction
    under construction

    1st as value, rest as equivalent

    ruins
    ruin
    ruined

    1st as value, rest as equivalent

    destroyed
    maybe same as ruins? or leave out

    collapsed
    damaged
    derelict

    1st as value, rest as equivalent

    disused
    not sure if this is really different to =yes

    temporary
    not sure if this is really different to =yes

    no
    fixme
    leave out

    Developer of Elevate mapstyle

Viewing 7 posts - 1 through 7 (of 7 total)

You must be logged in to reply to this topic.