Viewing 11 posts - 1 through 11 (of 11 total)
  • Author
    Posts
  • #45394
    Kriss72
    Participant

    With oruxmaps, on a part of the forest the elements are hidden (France_North_oam.osm.map).

    #45424
    Avatar photoTobias
    Keymaster

    That’s a problem with OSM data – the forest has layer=1, which means it should be rendered above the ground-layer (with roads etc.); this makes no sense.

    Developer of Elevate mapstyle

    #45426
    Avatar photoChristianK
    Keymaster

    Imo IT would make sense to remove Layers from landuse or natural in preprozessing
    Any drawbacks possible?

    #45436
    Avatar photoJohnPercy
    Participant

    There are a suprising number of landuse=* AND layer=* – most of them apparently due to incorrect mapping.
    However, what about: https://www.openstreetmap.org/way/162654920 which combines landuse=railway, manmade=bridge and layer=1 to map the outline of a railway bridge?

    Voluntary and Velocity themes - https://voluntary.nichesite.org

    #45446
    Avatar photoTobias
    Keymaster

    Imo IT would make sense to remove Layers from landuse or natural in preprozessing
    Any drawbacks possible?

    I think OSM Carto is doing this here, as it shows the forest below the roads:
    https://www.openstreetmap.org/way/37195165/
    The layer tag has just been removed btw.

    But you never know what strange tagging some people are using, see John’s example.

    Developer of Elevate mapstyle

    #45456
    Avatar photoChristianK
    Keymaster

    But you never know what strange tagging some people are using, see John’s example.

    🙂

    Ok, I added this:

    	<translation>
    		<name>landuse|natural clear layers</name>
    		<description>landuse|natural clear layers</description>
    		<match mode="and">
    			<tag k="landuse|natural" v=".*"/>
    			<tag k="Layer" v=".*"/>
    		</match>
    		<output>
    			<copy-all/>
    			<tag k="Layer" v="dummy"/>
    		</output>
    	</translation>

    This should do the job for 99,9%

    As for the Bridges: IMO There is not need for Layer Tags if the Theme is made with care.

    2 users thanked author for this post.
    #45458
    Avatar photoJohnPercy
    Participant

    As for the Bridges: IMO There is not need for Layer Tags if the Theme is made with care

    I’m not so sure about that. Tobias?

    Voluntary and Velocity themes - https://voluntary.nichesite.org

    #45460
    Avatar photoTobias
    Keymaster

    As for the Bridges: IMO There is not need for Layer Tags if the Theme is made with care

    I’m not so sure about that. Tobias?

    In John’s example the layer tag would be necessary if you want to display the landuse=railway below the rails in Elevate, as man_made=bridge isn’t in tag-mapping. The landuse would be rendered below the river, as landuses below waterways is the proper order in the theme. But it’s some not really relevant mapping. To have it displayed one would need the layer tag or have man_made=bridge in the map.

    The actual rails have bridge=yes and will be displayed.

    It’s probably fine with most use cases, but there are those exceptions which might need some analysation.

    Developer of Elevate mapstyle

    #45462
    Avatar photoTobias
    Keymaster

    We also had this example last year, which wouldn’t render correctly without layer:
    https://www.openandromaps.org/oam-forums/topic/render-differences

    So maybe it’s better to leave layers, at least if some kind of bridge is involved?

    Developer of Elevate mapstyle

    1 user thanked author for this post.
    #45464
    Avatar photoChristianK
    Keymaster

    OK

    	<translation>
    		<name>landuse|natural clear layers</name>
    		<description>landuse|natural clear layers</description>
    		<match mode="and">
    			<tag k="landuse|natural" v=".*"/>
    			<tag k="Layer" v=".*"/>
    			<notag k="bridge" v=".*"/>
    		</match>
    		<output>
    			<copy-all/>
    			<tag k="Layer" v="dummy"/>
    		</output>
    	</translation>
    2 users thanked author for this post.
    #45466
    Avatar photoTobias
    Keymaster

    Great, maybe also notag man_made=bridge?
    This should cover most cases. If there’s still something wrong we’ll probably hear it in the forum.

    Developer of Elevate mapstyle

    2 users thanked author for this post.
Viewing 11 posts - 1 through 11 (of 11 total)
  • You must be logged in to reply to this topic.