-
Posts
-
Hello, I think the issue was not discussed before, or I did not find the report
Beacon icons lose their background after zoom 15
For example with the theme Elevate.
This would be the right thing to do.
But in both OruxMaps beta and Cruiser app, the blue background for example disappears
Image attachment
In OruxMaps beta it happens since the last update of mapsforge libraries, I don’t know if it’s related
Thank you.Map themes probably need to use the new
Display.FORCEDoption in these rules.Documentation: https://github.com/mapsforge/mapsforge/blob/master/docs/Rendertheme.md#display
Implementation: https://github.com/mapsforge/mapsforge/pull/1717
Cruiser and Mapsforge developerSee also the discussion here:
https://github.com/mapsforge/mapsforge/pull/1586#issuecomment-3046372969
Cruiser and Mapsforge developerThis will be available in the next Mapsforge 0.26 release.
https://github.com/mapsforge/mapsforge/blob/master/docs/Changelog.md
Cruiser and Mapsforge developerSo, we have to wait for the various apps to implement this version of the Mapsforge engine before updating themes?
Also, there seems to be no backwards compatibility so it will be difficult (or impossible) to ensure a theme will work on apps that have updated the Mapsforge engine and those that have not yet done so? Perhaps I will have to write the command twice, once with display=always and once with display=forced?Voluntary and Velocity themes - https://voluntary.nichesite.org
I understand the problems.
This change was made by a community contribution trying to improve other things.
Unfortunately, it was impossible to catch and test this special case,
since none of us use “always” in such a way: combine theme icons,I have no problem to revert the “always” change and remove the “forced”,
so community will be happy and all themes and apps remain compatible.But someone must write and test the code and provide a pull request.
Then I can review the pull request.
Cruiser and Mapsforge developer1 user thanked author for this post.
In any case, instead of expecting the theme to combine icons with the “always” option,
it’s better to have these icons prepared as files in the theme folder and use them like other icons.
And that would work in all current and future applications.
Cruiser and Mapsforge developerWell, Emux, the hiking/biking signs x names use case will explode the number of icons you have to build. 100s, if not more.
Could you add a master switch in the theme header that makes always behave like forced – for the time of transitions of Apps. Because I think the new forced mode and always behaviour has value, too.In any case, instead of expecting the theme to combine icons with the “always” option,
it’s better to have these icons prepared as files in the theme folder and use them like other icons.
And that would work in all current and future applications.
Cruiser and Mapsforge developerI’m sorry, but combining icons for waymarks is much more efficient. display=always has been used for this at least in OAM since 2016, so it’s no unknown hack. Just because something isn’t mentioned in mapsforge documentation means that it can be broken is not a really good point – because so much in mapsforge isn’t well documented, and creative use of existing functions in theming and creating maps have made mapsforge in practice much better.
Changing the display=always behaviour after such a long time breaks compatibility, and compatibility was always a strength of mapsforge. Even adding a master switch in the theme header as Michael suggested should only change the behaviour to the new one, default behaviour should be the long established one.
Best regards,
TobiasDeveloper of Elevate mapstyle
If you do not want to change the icon files, then the solution is simple:
I will make a new Mapsforge release immediately with the “forced” option,
all apps can use the new release immediately and you can update the themes soon.
Cruiser and Mapsforge developerIf you do not want to change the icon files, then the solution is simple:
I will make a new Mapsforge release immediately with the “forced” option,
all apps can use the new release immediately and you can update the themes soon.
Cruiser and Mapsforge developerThat’s a no go. We usually wait a long time before raising the compatibility bar in OAM, and then only if it’s justified by a real gain for the users. Usually till most known apps have adapted to the new version, and then only if it adds value (there’s users who use old apps etc.). Using display=force instead of display=always for the same rendering doesn’t add any value, but breaks backward compatibility.
So why change the label for an existing and working function in the first place? Just use a different, e.g
display=sometimes for the new always, and render display=always same as display=forced.Developer of Elevate mapstyle
I agree with Tobias 100%. When looking into forums I see many older devices, reluctance to change a running App etc. etc.
Not the fanciest attitude, but very human, right?
Brute force can break an eco system, in nature as well as for IT solutions (for companies and end users and Apps alike).
Tobias’ proposal serves both purposes: you can innovate without breaking the Mapsforge eco system.
I strongly support.
Cheers
MichaelIn any case, instead of expecting the theme to combine icons with the “always” option,
it’s better to have these icons prepared as files in the theme folder and use them like other icons.
And that would work in all current and future applications.
Cruiser and Mapsforge developerI’m sorry, but combining icons for waymarks is much more efficient. display=always has been used for this at least in OAM since 2016, so it’s no unknown hack. Just because something isn’t mentioned in mapsforge documentation means that it can be broken is not a really good point – because so much in mapsforge isn’t well documented, and creative use of existing functions in theming and creating maps have made mapsforge in practice much better.
Changing the display=always behaviour after such a long time breaks compatibility, and compatibility was always a strength of mapsforge. Even adding a master switch in the theme header as Michael suggested should only change the behaviour to the new one, default behaviour should be the long established one.
Best regards,
Tobias“creative use” is a synonym to “hack”… And hacks won’t work in different implementations of the Mapsforge format, for example GPXsee won’t display “combined icons” either. If you want a universally working theme, you should stick to the documentation, not to what works in one version of a single implementation.
- The topic ‘OSMC beacon icons’ is closed to new replies.