-
Posts
-
creative use“ is a synonym to „hack“…
No. Especially not in this case. The original documentation was:
– always: an element will always be displayed regardless of space.
It doesn’t say neither: this shouldn’t be used for overlapping elements, nor it should be. Just always. But this is well within this documentation, and combining osmc symbols isn’t the only use case where overlapping symbols was the goal of the use of “always”. For the new version of “always”, using “priority” could have been enough.
And if you make an implementation of mapsforge which doesn’t work like the original one, seems like it’s not 100% compatible.Developer of Elevate mapstyle
1 user thanked author for this post.
Sorry, there is currently no other solution.
Mapsforge is open source, everyone must contribute code. 🙂Hack is to expect a map library to combine icons with a theme rule.
We never mentioned in the documentation that this is a supported feature.If you all want the best compatibility then:
Have such icons prepared as files in the theme folder and use them like other icons.
Cruiser and Mapsforge developer“always” has a defined semantics: no exception.
You accuse people of hacking when they believe in the well defined meaning of a word.
in fact your team is hacking language, which destroys common ground and communication.
just rename the new feature to priority or so and leave always as it was defined before. only then there will be compatibility and peace.Version 0.26.0 of Mapsforge and VTM is available on JitPack;
https://jitpack.io/#mapsforge/mapsforge
https://jitpack.io/#mapsforge/vtm
Cruiser and Mapsforge developerSorry, there is currently no other solution.
Mapsforge is open source, everyone must contribute code. 🙂Sorry, can’t code Java, else I would.
Hack is to expect a map library to combine icons with a theme rule.
We never mentioned in the documentation that this is a supported feature.But it worked in practice since introduction of this feature. As you wrote here:
https://github.com/mapsforge/mapsforge/pull/1586#issuecomment-2517043381
“So they should overlap with anything, other elements with or not “always”.”
Overlapping icons with display=always is now broken, either for the real use case of combining symbols or other ones.What about this solution mentionend here:
https://github.com/mapsforge/mapsforge/pull/1586#issuecomment-2517102211In any case, this is really just a minor change in the code, easily reverted (and un-reverted in the future if needed).
This sounds like the change of display=always was preliminary.
If you all want the best compatibility then:
Have such icons prepared as files in the theme folder and use them like other icons.That would mean 7800 icons instead of 235 (all possible back- and foreground combinations). No way.
I remember well when I had to design 3 different theme versions – one for all those stuck with rendertheme V3, one for Locus, and one for V4+. Not just for me, but for the users it was a challenge to know which one to use and what the differences are. So having real compatibility with the one default mapsforge implementation was a big benefit for everyone, thank you for that!
When now I have to make different versions again (one with display=always as it was introduced with rendertheme v4 in 2014, one with display=forced) it feels like going back to the dark ages.Developer of Elevate mapstyle
1 user thanked author for this post.
I think the discussion was initiated by Locus developers here:
https://github.com/mapsforge/mapsforge/pull/1586#issuecomment-3046372969I am 1 person maintaining Mapsforge and VTM all these years. 🙂
Everyone should not expect everything from 1 person.
Similar case with Christian here, more help is required.Please ask the developers of all these popular apps that use Mapsforge maps
to participate in Mapsforge development and contribute code.I am always open for improvements and changes,
but someone must make a pull request with code.
Cruiser and Mapsforge developerEmux, I understand your position and appreciate your efforts very much!
Or we could try what Michael suggested above:
rename the new feature to priority or so and leave always as it was defined before
I can check if and how this is possible.
Cruiser and Mapsforge developerYes, that’s what I meant here:
So why change the label for an existing and working function in the first place? Just use a different, e.g
display=sometimes for the new always, and render display=always same as display=forced.Just use for the new “always” a different label, and everything’s fine for everyone, e.g. display=emphasized. display=priority is too close to priority=* IMO,
Developer of Elevate mapstyle
Or display=preferred, maybe?
Voluntary and Velocity themes - https://voluntary.nichesite.org
1 user thanked author for this post.
Can you test with the desktop Cruiser (Beta) from here to see if everything is ok again?
It uses Mapsforge with restored display=”always” rendering.
Cruiser and Mapsforge developerThanks Emux, quick test shows that Waymarks work as before, in the screenshot the left marked area. Here a background symbol, a foreground symbol and a reference caption are combined, so it’s not just hacking images here 😉
In the right marked area you can see symbol for a mountain pass, which also uses display=always, but to be displayed in the background. So the overlapping small bus stop symbol and others can always be seen as well. Another use of display=always. OK, in this example the bus stop has no display=always and would still be shown because of higher priority than the mountain pass, but other symbols with display=always would eliminate the mountain pass symbol with the new always implementation.
Thanks a lot!Developer of Elevate mapstyle
- The topic ‘OSMC beacon icons’ is closed to new replies.