Viewing 11 posts - 1 through 11 (of 11 total)
  • Author
    Posts
  • #57046
    Avatar photovsa
    Participant

    Hallo Christian,

    please, is possible add this?
    man_made=tower
    tower:type=watchtower
    https://www.openstreetmap.org/node/12451430001

    and convert to display a similar symbol (tower:type=observation) ?

    #57050
    Avatar photoTobias
    Keymaster

    As it’s use is primarily military, I think that a different rendering to a observation tower makes sense for a map for outdoor use, and maybe make use of access tags, e.g. only render with access=yes.

    Developer of Elevate mapstyle

    #57069
    Avatar photoChristianK
    Keymaster

    I added tower=watchtower to tagmapping

    conversion as usual

    	<translation>
    		<name>Transform Towers</name>
    		<description>Mapsforge cannot rendert tower:type for some reasons so we have to transform into tower=tower:type, Tower without a type stay untouched</description>
    		<match mode="or">
    			<tag k="tower:type" match_id="type" v="(.*)"/>
    		</match>
    		<output>
    			<copy-unmatched/>
    			<tag k="tower" from_match="type" v="{1}"/>
    		</output>
    	</translation>	
    
    	<translation>
    		<name>Transform man_made=communications_tower to tower=communication</name>
    		<description>Transform man_made=communications_tower to tower=communication</description>
    		<match mode="or">
    			<tag k="man_made" v="communications_tower"/>
    		</match>
    		<output>
    			<copy-unmatched/>
    			<tag k="tower" v="communication"/>
    		</output>
    	</translation>	
    1 user thanked author for this post.
    Avatar photo vsa
    #57840
    Avatar photoTobias
    Keymaster

    Hi Christian,
    just wanted to add tower=watchtower, but only with access=acc_yes|permissive|destination|permit. But access=acc_yes and permissive is missing in tag-mapping… probably wasn’t needed till now because of tagtransform. But adding in for just this case would add 2 million of unneeded access=yes to all kinds of POIs/tags… what now? Only add accessible watchtowers? Or separate them in tower=watchtower_private and tower=watchtower_accessible?
    Thanks,
    Tobias

    Developer of Elevate mapstyle

    #57841
    Avatar photoChristianK
    Keymaster

    Hello Tobias,

    I would go the other way and skip tower=watchtower if there is an access=acc_no|private|…. in the theme

    I Checked tower:type=watchtower and man_made=tower in my area and there are some I know open for public and none has a positive access tag.

    I added access=permissive to tagmapping.

    Christian

    #57842
    Avatar photoTobias
    Keymaster

    I wouldn’t assume that all watchtowers without access=no are accessible. As the wiki says “it’s primary use is military”, so access=no would be the default in my opinion and access=yes the rare exception.

    Developer of Elevate mapstyle

    #57847
    Avatar photoChristianK
    Keymaster

    This would bring 16 watchtowers in whole europe on the map.

    None of the, so far I know none_military, watchtowers in lower and upper_austria has access=yes.

    Well, thats basicly not our fault that readings manuals is totaly out of fashinon and tagging by chance is common – however it makes rendering watchtowers with access=yes IMO useless.

    So the question is how to handle – I can, of couse, eliminate watchtowers w/o access=yes per tagtransform…..

    https://overpass-turbo.eu/s/21kt

    #57850
    Avatar photoTobias
    Keymaster

    There are some more if you include access=permit and access=customers:
    https://overpass-turbo.eu/s/21l7

    The problem for me – I think the tag is only relevant in my usage with Elevate if a tower is accessible, either as a tourist attraction or like an observation tower. I don’t want to render a symbol for every tower on a medieval city wall, a castle or a prison. So of course lots of those would not be rendered.
    I can also live with them not having shown at all – as at the moment the mapping doesn’t really allow to differ between every kind of watch tower and those that are more relevant for Elevate.

    Developer of Elevate mapstyle

    1 user thanked author for this post.
    #57851
    Avatar photoChristianK
    Keymaster

    I will eliminate all watchtowers w/o

    access=yes|permit|customers

    per tagTransform.
    Then its up to the mappers to tag things in a correct way.
    The rule looks a little bit strange but its working.

    	<translation>
    		<name>eliminate watchtowers w/o access</name>
    		<description>eliminate watchtowers w/o access</description>
    		<match mode="and">
    			<tag k="tower" v="watchtower"/>
    			<notag k="access" v="yes|permit|permissive|customers|customer"/>
    		</match>
    		<output>
    			<copy-unmatched/>
    		</output>
    	</translation>
    3 users thanked author for this post.
    #57858
    Avatar photoJohnPercy
    Participant

    Best, I think. Locally, someone has mapped all the CCTV masts on the university campus as watchtowers. Hopeless!

    Voluntary and Velocity themes - https://voluntary.nichesite.org

    2 users thanked author for this post.
    #58021
    Avatar photoTobias
    Keymaster

    Now included in Elevate 5.6, rendered as equivalent to observation towers.

    Developer of Elevate mapstyle

    1 user thanked author for this post.
Viewing 11 posts - 1 through 11 (of 11 total)
  • You must be logged in to reply to this topic.