Betrachte 15 Beiträge - 1 bis 15 (von insgesamt 18)
  • Autor
    Beiträge
  • #43942

    EugeneMaz
    Teilnehmer

    Hi! First of all, I really like both OpenAndroMaps and Elevate style you are doing, thank you for this.

    I just noticed that some waymark symbols are not rendered properly. To give you example in my area:
    1) osmc symbol is not rendered correctly for the routes marked with brown_* (e.g. brown_bar). For example, this route is rendered just with white square.
    Example 1
    For what I understand, it is related to the absence of brown foreground colours in the osmc_foreground.txt for the tag resolving. Is it possible to add them?

    2) There are a couple of black_dot routes for which osmc symbol is not rendered in the same area. And here I don’t understand why. For example, for this route, the symbol is not rendered:
    Example 2

    Cheers,

    Eugene

    Update: Ok, it seems that the reason it doesn’t work in the case 2 it is because the route is labelled as black::black_dot not as black:white:black_dot. I’m not sure whether such use is allowed, but there are quite a lot of similar labels in this area. Would it be possible to handle this?

    • Dieses Thema wurde vor vor 3 Monaten, 4 Wochen von  EugeneMaz bearbeitet.
    • Dieses Thema wurde vor vor 3 Monaten, 4 Wochen von  EugeneMaz bearbeitet. Grund: New info
    #43960

    ikoms
    Teilnehmer

    Salut Eugene

    I guess you have to create your own wm_frg_brown_bar.svg and put it in the folder ele-res

    Then you have to ad
    </rule>
    <rule e=“node“ k=“osmc_foreground“ v=“wmfg_brown_bar“>
    <symbol src=“file:ele-res/wm_frg_brown_bar.svg“ display=“always“ symbol-height=“12″ />
    to the proper section in the file elevate.xml

    Bonne chance
    Urs

    • Diese Antwort wurde vor vor 3 Monaten, 4 Wochen von  ikoms bearbeitet.
    #43964

    EugeneMaz
    Teilnehmer

    Salut Urs,

    Thanks for the reply, I did as you suggested but it doesn’t seem to work… At least nothing has changed. I wounder if the tag value „wmfg_brown_bar“ even exists in the map file. In this case the theme tweaking wouldn’t help.

    #43970
    Tobias
    Tobias
    Verwalter

    Hi Eugene,
    only the symbols/colors listed here are supported:
    https://www.openandromaps.org/map-basics-2/osmcsymbols
    If something is missing, Christian can add it but he’s traveling right now.
    He also can tell you if values „::“ can be processed.
    Best regards,
    Tobias

    Developer of Elevate mapstyle

    #43999

    EugeneMaz
    Teilnehmer

    Thank you Tobias,

    This is what I thought, let’s hope Christian will have some time to add these features when he is back. Unless he has some issues with the brown colour, the only one missing in the foregrounds list :D

    Best,

    Eugene

    #44003
    Tobias
    Tobias
    Verwalter

    Unless he has some issues with the brown colour, the only one missing in the foregrounds list

    Probably not, it’s just not contained in the value definition of the Wiki:
    https://wiki.openstreetmap.org/wiki/Key:osmc:symbol

    Curiously it also says:

    These tables are currently outdated due to a major update of the values. Check this complete list of symbols.

    Seems like the Wiki is outdated in since 2013…

    Developer of Elevate mapstyle

    #44567

    EugeneMaz
    Teilnehmer

    Just in case if Christian has time and desire to extend the list of osmc symbols supported, I’ve made a small analysis of osmc:symbol tag from taginfo.openstreetmap.org/. I’ve only extracted the values (separately for waycolor, background and foreground) that meet all the following conditions:
    1) are valid tags according to this and this lists. (Since wiki says itself that it is outdated)
    2) are used at least once in osm-database
    3) are NOT in the list of osmc:symbols supported by OpenAndroMaps (https://www.openandromaps.org/map-basics-2/osmcsymbols)

    I also counted the number of appearances of each value in the osm-database and sorted the list by this criterium. The results are in the attached files (they are actually .csv files but I had to change the extension to .txt in order to be able to upload them). You will see that there are many values that appear only a couple of times in the database but there are also some that have several hundreds of appearances but not supported by OpenAndroMaps at the moment… It might be worth adding them ;)

    Best,

    Eugene

    2 users thanked author for this post.
    #44976
    ChristianK
    ChristianK
    Verwalter

    Ok, I satarted working on this issue.

    First: There was a bug in tagmapping:
    wmfg_blue_right
    wmfg_green_right
    wmfg_orange_right
    wmfg_red_right
    wmfg_white_right
    hat no leading „wmfg_“, this resolved and will take effekt end of dezember (as all improvements from now on)

    For me the support shold be limited to the rules lonvia has set:
    https://hiking.waymarkedtrails.org/help/rendering/osmc

    For background and colors this is actual the case.
    Background IMO could be fully supported as in Lonvia, this is no big deal:

    
    wmbg_black
    wmbg_black_circle
    wmbg_black_frame
    wmbg_black_round
    wmbg_white
    wmbg_white_circle
    wmbg_white_frame
    wmbg_white_round
    wmbg_yellow
    wmbg_yellow_circle
    wmbg_yellow_frame
    wmbg_yellow_round
    wmbg_red
    wmbg_red_circle
    wmbg_red_frame
    wmbg_red_round
    wmbg_green
    wmbg_green_circle
    wmbg_green_frame
    wmbg_green_round
    wmbg_blue
    wmbg_blue_circle
    wmbg_blue_frame
    wmbg_blue_round
    wmbg_brown
    wmbg_brown_circle
    wmbg_brown_frame
    wmbg_brown_round
    wmbg_orange
    wmbg_orange_circle
    wmbg_orange_frame
    wmbg_orange_round
    wmbg_gray
    wmbg_gray_circle
    wmbg_gray_frame
    wmbg_gray_round
    wmbg_purple
    wmbg_purple_circle
    wmbg_purple_frame
    wmbg_purple_round
    

    The problem is the foreground.
    Full support would mean ~300 tags PLUS the non standard ones we already support like „horse“ „L“ „bowl“ aso.
    IMO too much.

    @eugenes list would add 117 additional foregrounds,
    47 with >= 10 counts
    65 with >= 5 counts
    etc..

    @tobias: The question is how many foregrounds we should add
    For me thats easy, 95% of the workload is on you with svgs and theme. And we have to take into account that every line in theme eats resources on Smartphone.

    For the future I would suggest to limit support (more or less) for OSMC like Lonvia does.

    Best regards
    Christian

    #44980
    Tobias
    Tobias
    Verwalter

    @tobias: The question is how many foregrounds we should add
    For me thats easy, 95% of the workload is on you with svgs and theme. And we have to take into account that every line in theme eats resources on Smartphone.

    There’s always the possibility to have something in the map but not in the theme ;-)
    I also think Lonvia is more than enought. It might also occur that we add something which isn’t shown because there are two routes on the same way, too… so probably striving for perfection isn’t worth it as most of the times here.

    Developer of Elevate mapstyle

    #45009
    ChristianK
    ChristianK
    Verwalter

    I updated the tagmapping.

    As for color/textcolor I added „gray“ this was a bug.
    Full support for osmc:background as in Lonvia is added.

    Foreground: I added all tags with more than 5 ouccurances.
    @tobias will inform everyone which Symbols he finally adds to the Theme.

    • Diese Antwort wurde vor vor 2 Wochen, 3 Tage von ChristianK ChristianK bearbeitet.
    2 users thanked author for this post.
    #45032
    Tobias
    Tobias
    Verwalter

    Christian, while you’re at it: it might make sense to add the waymark colors for the ways earlier in the tag-mapping. At the moment in the tag-mapping urban it’s ZL 13, which is ok for lwn/rwn; but for iwn/nwn it might make sense to show the colors at the same level as the „normal“ routes.
    At best it would be similar – osmc_color for iwn/nwn at 7, lwn/rwn at 12 – so users can choose to show only routes with waymarks colors (as it makes sense in eastern eurpean countries) or the colors by priority.

    Developer of Elevate mapstyle

    #45046
    ChristianK
    ChristianK
    Verwalter

    Yes, that sounds good !

    So
    iwn/nwn set to 7
    lwn/rwn set to 12

    Plus zoom_override from iwn/nwn to osmc_color

    Done

    1 Teilnehmer(n) gefällt dieser Beitrag
    #45085

    EugeneMaz
    Teilnehmer

    Hi!

    Thank you, Christian and Tobias, for having answered and the updating the tagmapping!

    Could you please answer also the 2nd part of my initial post, on whether osmc:symbols with skipped background might be supported?

    Update: Ok, it seems that the reason it doesn’t work in the case 2 it is because the route is labelled as black::black_dot not as black:white:black_dot. I’m not sure whether such use is allowed, but there are quite a lot of similar labels in this area. Would it be possible to handle this?

    I suppose the easiest way would be just considering waycolor::fg_color the same as waycolor:white:fg_color .

    Best,

    Eugene

    #45087
    ChristianK
    ChristianK
    Verwalter

    @tobias

    Are you able to render a foreground if the background is missing or (eg) set to „none“ or „missing“.
    Replacing a missing background with „white“ is not what I like…

    #45103
    Tobias
    Tobias
    Verwalter

    black:

    At the moment it doesn’t work, probably all osmc:symbol with missing backgrounds are filtered. But a <rule e="node" k="osmc" v="osmc_yes"><rule e="node" k="osmc_background" v="~"> should work.

    Developer of Elevate mapstyle

    • Diese Antwort wurde vor vor 1 Woche, 6 Tage von Tobias Tobias bearbeitet.
Betrachte 15 Beiträge - 1 bis 15 (von insgesamt 18)

Sie müssen angemeldet sein, um zu diesem Thema eine Antwort verfassen zu können.